Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chip-tool] Add Nullable supports in test value expressions #17989

Merged
merged 3 commits into from
May 3, 2022
Merged

[chip-tool] Add Nullable supports in test value expressions #17989

merged 3 commits into from
May 3, 2022

Conversation

vivien-apple
Copy link
Contributor

Problem

The window covering test suite uses a Nullable value into an expression that validates some test results.

Change overview

  • Add supports for chip::Nullable into expressions

Testing

The test runs but it is failing for now as there is a bug in the window covering cluster. This is why it is disabled. @jmeg-sfy will turn it on soon.

@vivien-apple vivien-apple self-assigned this May 3, 2022
@boring-cyborg boring-cyborg bot added the app label May 3, 2022
@restyled-io restyled-io bot mentioned this pull request May 3, 2022
Closed
@vivien-apple vivien-apple force-pushed the NullableExpression branch from ccbc16c to b84b297 Compare May 3, 2022 07:43
@github-actions
Copy link

github-actions bot commented May 3, 2022 •
edited
Loading

PR #17989: Size comparison from 91513eb to b84b297

Decreases (2 builds for linux)
platform target config section 91513eb b84b297 change % change
linux chip-tool debug (read only) 8978773 8978069 -704 -0.0
.rodata 463829 463733 -96 -0.0
.text 7191797 7191189 -608 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8818612 8817988 -624 -0.0
.rodata 431540 431460 -80 -0.0
.text 6928564 6928020 -544 -0.0
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 91513eb b84b297 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688911 688911 0 0.0
(read/write) 163344 163344 0 0.0
.bss 75236 75236 0 0.0
.data 3400 3400 0 0.0
.rodata 102303 102303 0 0.0
.text 586124 586124 0 0.0
lock-ftd LP_CC2652R7 (read only) 676775 676775 0 0.0
(read/write) 166736 166736 0 0.0
.bss 73548 73548 0 0.0
.data 3224 3224 0 0.0
.rodata 94359 94359 0 0.0
.text 581936 581936 0 0.0
lock-mtd LP_CC2652R7 (read only) 625527 625527 0 0.0
(read/write) 146352 146352 0 0.0
.bss 69268 69268 0 0.0
.data 3224 3224 0 0.0
.rodata 94247 94247 0 0.0
.text 530792 530792 0 0.0
pump-app LP_CC2652R7 (read only) 661275 661275 0 0.0
(read/write) 183476 183476 0 0.0
.bss 73764 73764 0 0.0
.data 3256 3256 0 0.0
.rodata 80387 80387 0 0.0
.text 580404 580404 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654171 654171 0 0.0
(read/write) 190380 190380 0 0.0
.bss 73820 73820 0 0.0
.data 3220 3220 0 0.0
.rodata 83323 83323 0 0.0
.text 570364 570364 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626370 626370 0 0.0
.app_xip_area 528904 528904 0 0.0
.bss 80116 80116 0 0.0
.data 696 696 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 625082 625082 0 0.0
.app_xip_area 529080 529080 0 0.0
.bss 78692 78692 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574218 574218 0 0.0
.app_xip_area 468596 468596 0 0.0
.bss 88016 88016 0 0.0
.data 572 572 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 908184 908184 0 0.0
(read/write) 134528 134528 0 0.0
.bss 132472 132472 0 0.0
.data 2052 2052 0 0.0
.text 908176 908176 0 0.0
BRD4161A+rpc (read only) 942544 942544 0 0.0
(read/write) 151208 151208 0 0.0
.bss 148952 148952 0 0.0
.data 2256 2256 0 0.0
.text 942536 942536 0 0.0
BRD4161A+rs911x (read only) 746564 746564 0 0.0
(read/write) 128752 128752 0 0.0
.bss 126772 126772 0 0.0
.data 1980 1980 0 0.0
.text 746556 746556 0 0.0
lock-app BRD4161A+wf200 (read only) 916560 916560 0 0.0
(read/write) 127540 127540 0 0.0
.bss 125604 125604 0 0.0
.data 1936 1936 0 0.0
.text 916552 916552 0 0.0
window-app BRD4161A (read only) 845432 845432 0 0.0
(read/write) 132616 132616 0 0.0
.bss 130648 130648 0 0.0
.data 1964 1964 0 0.0
.text 845424 845424 0 0.0
esp32 all-clusters-app c3devkit (read only) 999696 999696 0 0.0
(read/write) 1474506 1474506 0 0.0
.dram0.bss 68376 68376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 207248 207248 0 0.0
.flash.text 999696 999696 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054823 1054823 0 0.0
(read/write) 476936 476936 0 0.0
.dram0.bss 73896 73896 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 237028 237028 0 0.0
.flash.text 1049439 1049439 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684236 684236 0 0.0
.bss 81320 81320 0 0.0
.data 2008 2008 0 0.0
.text 599204 599204 0 0.0
lock k32w061+release (read/write) 729052 729052 0 0.0
.bss 81744 81744 0 0.0
.data 1968 1968 0 0.0
.text 643636 643636 0 0.0
linux all-clusters-app debug (read only) 2729993 2729993 0 0.0
(read/write) 173144 173144 0 0.0
.bss 83360 83360 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 81656 81656 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1008 1008 0 0.0
.rodata 235173 235173 0 0.0
.text 2320194 2320194 0 0.0
bridge-app debug+rpc (read only) 1885089 1885089 0 0.0
(read/write) 120440 120440 0 0.0
.bss 71360 71360 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40312 40312 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 688 688 0 0.0
.rodata 160449 160449 0 0.0
.text 1602242 1602242 0 0.0
chip-tool debug (read only) 8978773 8978069 -704 -0.0
(read/write) 576464 576464 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 546472 546472 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 463829 463733 -96 -0.0
.text 7191797 7191189 -608 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8818612 8817988 -624 -0.0
(read/write) 642641 642641 0 0.0
.bss 40913 40913 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 581752 581752 0 0.0
.dynamic 560 560 0 0.0
.got 14960 14960 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 431540 431460 -80 -0.0
.text 6928564 6928020 -544 -0.0
lighting-app debug+rpc (read only) 2319465 2319465 0 0.0
(read/write) 151392 151392 0 0.0
.bss 73408 73408 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 184617 184617 0 0.0
.text 1968594 1968594 0 0.0
lock-app debug (read only) 2225665 2225665 0 0.0
(read/write) 145976 145976 0 0.0
.bss 72032 72032 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66760 66760 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 194353 194353 0 0.0
.text 1871410 1871410 0 0.0
ota-provider-app debug (read only) 2054321 2054321 0 0.0
(read/write) 138992 138992 0 0.0
.bss 71424 71424 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60104 60104 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 175099 175099 0 0.0
.text 1722098 1722098 0 0.0
ota-requestor-app debug (read only) 2085377 2085377 0 0.0
(read/write) 141800 141800 0 0.0
.bss 72064 72064 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 171372 171372 0 0.0
.text 1755394 1755394 0 0.0
shell debug (read only) 2555065 2555065 0 0.0
(read/write) 197104 197104 0 0.0
.bss 114088 114088 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 75920 75920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 216722 216722 0 0.0
.text 2176818 2176818 0 0.0
thermostat-no-ble arm64 (read only) 2360964 2360964 0 0.0
(read/write) 174593 174593 0 0.0
.bss 86273 86273 0 0.0
.data 1496 1496 0 0.0
.data.rel.ro 79048 79048 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 376 376 0 0.0
.rodata 145828 145828 0 0.0
.text 1985984 1985984 0 0.0
tv-app debug (read only) 2840897 2840897 0 0.0
(read/write) 276608 276608 0 0.0
.bss 189272 189272 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76456 76456 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 217163 217163 0 0.0
.text 2441682 2441682 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2418124 2418124 0 0.0
.bss 205884 205884 0 0.0
.data 5856 5856 0 0.0
.text 1380724 1380724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177707 1177707 0 0.0
bss 139600 139600 0 0.0
rodata 150804 150804 0 0.0
text 808644 808644 0 0.0
p6 all-clusters-app default (read/write) 2528592 2528592 0 0.0
.bss 139256 139256 0 0.0
.data 2792 2792 0 0.0
.text 1486856 1486856 0 0.0
light-app default (read/write) 2419192 2419192 0 0.0
.bss 132720 132720 0 0.0
.data 2592 2592 0 0.0
.text 1377456 1377456 0 0.0
lock-app default (read/write) 2428480 2428480 0 0.0
.bss 132544 132544 0 0.0
.data 2552 2552 0 0.0
.text 1386744 1386744 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 804448 804448 0 0.0
bss 72232 72232 0 0.0
noinit 40416 40416 0 0.0
text 571272 571272 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 7c00822 into project-chip:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@andy31415 andy31415 Awaiting requested review from andy31415

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees

@vivien-apple vivien-apple

Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vivien-apple @tcarmelveilleux @andy31415 @bzbarsky-apple @jmeg-sfy